CSLA .NET Contrib

Commented Issue: EditableRootList - AllowNew

Tom_W — Tue, 02 Jun 2009 14:15:52 GMT

When binding EditableRootList to the .Net DataGridView new rows cannot be added because although AddNewCore is implemented, the AllowNew property is not set in the list's constructor.

Proposed solution is to modify the list's constructor:

#region Factory Methods
private CustomerSubCategoryEdList()
{ /* require use of factory method */
this.AllowNew = true;
}

or in CodeSmith language:

<%=Indent(i, true)%>#region Factory Methods
<%=Indent(i)%>private <%=objInfo.Name%>()
<%=Indent(i++)%>{
<%=Indent(i)%>/* require use of factory method */
<%=Indent(i)%>this.AllowNew = true;
<%=Indent(i--)%>}
Comments: ** Comment from web user: Tom_W **

Apologies, last line of the CS code should read:
<%=Indent(--i)%>}

Created Issue: EditableRootList - AllowNew

Tom_W — Mon, 01 Jun 2009 19:00:56 GMT

Created Issue: Is CSLA 3.6 CodeSmith generation dormient or missing types?

MADCookie — Tue, 26 May 2009 16:23:49 GMT

Shouldn't there be a few more stereo type templates for CodeSmith? I don't see switchable, command or name value list. Has CSLA Contrib work gone to sleep on creating CodeSmith templates using CSLA 3.6 objects? I appreciate all the work that "RickySupit" has already done. I hope my message here is not offending anyone or the dismissing the hard work that has already been accomplished.

I have seen that Code Smith 5.1 has a developer redoing all the CSLA 3.6 templates in the paid version of CodeSmith. I think the community here has a lot experience that shouldn't be lost.

Created Issue: Legacy Database has columns with "_" Underscores

ejlatstl — Tue, 24 Feb 2009 20:30:56 GMT

Hi All,

The generated code does not carry the underscores through. Any thoughts on how to deal with this?

Thanks,

Ed

Created Issue: Possible mismatch between editable and read-only classes

mrlucmorin — Mon, 23 Feb 2009 14:10:46 GMT

Hi,

I've noticed that when you create a read-only class for a given table, if the column in nullable in the DB, the generated CLR type will also be a nullable, for example int?

On the other hand, the editable classes will not generate a CLR nullable type.

I've narrowed this difference to the use of "prop.Type" instead of "prop.NativeType" on lines 12 & 24 of PropertiesMethods.inc. On the other hand, ReadOnlyProperties.inc does use NativeType.

Shouldn't we use NativeType for editable objects too ?

Regards.

Created Issue: DataPortalUpdate.inc possible error

mrlucmorin — Sun, 22 Feb 2009 20:07:49 GMT

In the DataPortalUpdate.inc file, the code for both DataPortal_Insert() and DataPortal_Update() is generated. The thing is that in both cases, the treatment of child objects is different.

Here’s how DataPortal_Insert() handles it:

<%=Indent(i)%>//Update Child object(s)
<%}%>
<% foreach (PropertyInfo prop in objInfo.ChildCollection) { %>
<%=Indent(i)%>DataPortal.UpdateChild(ReadProperty(<%=prop.PropertyInfoName%>), this);
<% } %>

And here’s how DataPortal_Update() handles it:

<%if(objInfo.ChildCollection.Count>0) {%>

<%=Indent(i)%>//Insert Child object(s)
<%=Indent(i)%>FieldManager.UpdateChildren(this);
<%}%>

So, in one case we call DataPortal.Update() for each child property, and in the other one we rely on FieldManager.UpdateChildern() to do the job.

The same observation also applies to the ChildUpdate.inc file.

In his book, Rocky seems to advocate the use of FieldManager.UpdateChildren() (see p. 421 in his 2008 c# book). Is there a reason to use DataPortal.UpdateChild() instead ?

Created Issue: Child of Child template error

mrlucmorin — Thu, 19 Feb 2009 15:55:57 GMT

The situation seems to arise when Child objects have Child themselves.

On line 22 of ChildDelete.inc, you reference the “data” variable like so:

<%=Indent(i)%>DataPortal.UpdateChild(ReadProperty(<%=prop.PropertyInfoName%>), data.<%=prop.DbRefTableName%>);

The problem is that at that point, the “data” variable is not yet defined. Here are the surrounding lines from ChildDelete.inc:

<%if(objInfo.ChildCollection.Count>0) {%>
<%=Indent(i)%>//Delete child object(s)
<%}%>
<% foreach (PropertyInfo prop in objInfo.ChildCollection) { %>
<%=Indent(i)%><%=prop.Name%>.Clear();
<%=Indent(i)%>DataPortal.UpdateChild(ReadProperty(<%=prop.PropertyInfoName%>), data.<%=prop.DbRefTableName%>);
<% } %>
<%=Indent(i)%>var data = new <%=objInfo.DalNamespace%>.<%=objInfo.EntityName%>()

So we see that within the “objInfo.ChildCollection” iteration, we generate “data.<%=prop.DbRefTableName%>” before the definition of “data”.

By comparing the ChildDelete.inc to DataPortalDelete.inc, it’s not clear to me why we pass “data.<%=prop.DbRefTableName%>” as second parameter to the DataPortal.UpdateChild() method. In DataPortalDelete.inc, we pass “this” instead, as shown by the corresponding lines from DataPortalDelete.inc:

<%if(objInfo.ChildCollection.Count>0) {%>
<%=Indent(i)%>//Delete Child object(s), which may contain concurrency check
<%}%>
<% foreach (PropertyInfo prop in objInfo.ChildCollection) { %>
<%=Indent(i)%><%=prop.Name%>.Clear();
<%=Indent(i)%>DataPortal.UpdateChild(ReadProperty(<%=prop.PropertyInfoName%>), this); // <------------------- here
<% } %>
<%if(objInfo.ChildCollection.Count>0) {%><%=Indent(0)%><%}%>
<%=Indent(i)%>var data = new <%=objInfo.DalNamespace%>.<%=objInfo.EntityName%>()

I have verified against the 3.5 version, and the same situation is present.

So I think it should be "this" instead of “data.<%=prop.DbRefTableName%>”.

Thank you.

Commented Issue: Support for CSLA 3.6

rfcdejong — Wed, 18 Feb 2009 17:12:47 GMT

Hi,

Are you planning on supporting CSLA 3.6 ? Or is the current state of the templates good enough so there's no big difference ?

Thank you
Comments: ** Comment from web user: rfcdejong **

For me as well, because we are working on CSLA 3.6..

There seems to be no IMobileObject on the SmartInt32 etc.
And no TypeConverter defined.

I think that it's needed because we are using WPF.

Source code checked in, #46985

RickySupit — Wed, 18 Feb 2009 02:52:13 GMT

fix: - UpdateChild incorrectly pass data variable on ChildDelete.inc

Created Issue: Nullable Char Issue

Tron5000 — Fri, 06 Feb 2009 16:43:59 GMT

Nullable chars in the Linq-to-SQL DAL are currently mapped to strings by the CSLA 3.5 codesmith EditableRoot template. This is dandy except for the fact that the conversion between these two different types is not accounted for in the generated DataPortal_Fetch, DataPortal_Insert and DataPortal_Update methods. Could someone please add a fix to the source code?

Thanks so much to the contributors for all your hard work - these templates are really useful!

Source code checked in, #46120

RickySupit — Sun, 25 Jan 2009 23:51:00 GMT

CodeSmith CS templates for CSLA 3.6: initial version Changes from v3.5: - remove redundant argument on LoadProperty, ReadProperty, GetProperty, SetProperty, RegisterProperty - use GetPropertyConvert, SetPropertyConvert, LoadPropertyConvert when assignment of unequal types. - add friendly name to RegisterProperty. - DbConnection to use DalNamespace as prefix. - fix: update is ignored changed value is default value. Move and use Attach(data, true) inside IsSelfDirty. - use UpdateChildren instead of UpdateChild on XX_Insert. ReadProperty has bug when property is lazy-load.

Commented Issue: ErrorWarnInfoProvider

tiago — Tue, 13 Jan 2009 00:44:00 GMT

Hi, I can not implement ErrorWarnInfoProvider in Example.Utility project.
I need to fire ValidationRules.CheckRules for error severity = warning or information in DataProtal Create and Data Portal Fetch Operations. The error provider only fires error severity = error because bussiness base object return isvalid= false and error severity = warning or information, not return isvalid=false so not be fired .
I want to invoke ValidationRules.CheckRules and the ErrorWarnInfoProvider show me all icons for all the types errors.
I have tried to modify IDataerrorInfo Properties in Core.BussinessBase to show broken rules warning and information in error provider, but no works.
Any ideas?
Thanks in advance
Comments: ** Comment from web user: tiago **

Try this version

Created Issue: ErrorWarnInfoProvider

luisxvarg — Tue, 30 Dec 2008 15:59:04 GMT

Created Issue: Support for CSLA 3.6

mrlucmorin — Tue, 23 Dec 2008 16:10:44 GMT

Hi,

Are you planning on supporting CSLA 3.6 ? Or is the current state of the templates good enough so there's no big difference ?

Thank you

Commented Issue: ErrorTreeView doesn't display broken grandchild objects

Alef — Wed, 17 Dec 2008 15:55:19 GMT

In the example you have a root, child and grandchild.
The ErrorTreeView doesn't display broken rules of the grandchildren in the following case:

Root doesn't have children when started : (put the following lines in comment)

Root.vb :
Public Shared Function NewRoot() As Root
Dim chld As New Root
'Dim gc As Child
'gc = Child.NewChild("Child 1")
'chld.Children.Add(gc)
'gc = Child.NewChild(String.Empty)
'chld.Children.Add(gc)
'gc = Child.NewChild("Child 3")
'chld.Children.Add(gc)
chld.ValidationRules.CheckRules()
Return chld
End Function

and when creating a child there are no broken rules (automatically some grandchilds are created in the example, let the grnadchilds have the broken rules, so for the grandchild don't change anything, only put the broken rules of a child object in comment)

Child.vb
Protected Overrides Sub AddBusinessRules()
MyBase.AddBusinessRules()
'ValidationRules.AddRule(AddressOf Csla.Validation.CommonRules.StringRequired, "Name")
'ValidationRules.AddRule(Of Child, Csla.Validation.RuleArgs)( _
' AddressOf ValidateValue, New Csla.Validation.RuleArgs("SomeValue"))
End Sub

You'll see when you create a new child object in the UI automatically some grandchilds are created with broken rules. But the ErrorTreeView doesn't show it.
Comments: ** Comment from web user: Alef **

You can solve the problem by modifying the method FillNode in the class ErrorTreeNode:

put in comment the check for item.IsVisible.

Only disadvantage is that we see an empty node Children, but now when adding a child you'll see in the ErrorTreeView the broken rules of the grandchilds. (the example create automatically some broken grandchilds when a child object is created)

Do you have an idea how to avoid the empty node Children?

Commented Issue: Nullable types

Alef — Wed, 17 Dec 2008 11:12:23 GMT

It would be nice if the templates generated nullable types for integer and booleans.

There are cases where we want to distinguish between a database null and a 0 integer, and need to know if a required integer field has been entered. In some cases 0 is a valid value and we want to disquish it from a user entering blank. Defaulting blank to another non-zero value does not work in all scenarios either.

The same situation exists with boolean variables where we may want to treat a user answer no to a question (insert false) as different than the user not answering the question (insert null).
Comments: ** Comment from web user: Alef **

I changed the TemplateBase as you suggested but nothing changes in the generated code in CSLA 3.5. (I've set in my xml file AllowDbNull to true)

What is working for me is changing eg the property Type from int to int?. When you are using XML Spy you don't see int? in the combo list, but you can type it.

Created Issue: ErrorTreeView doesn't display broken grandchild objects

Alef — Sat, 13 Dec 2008 19:05:09 GMT

Closed Issue: ExcuteFetch method + ValidationRules.CheckRules bug

RickySupit — Sat, 13 Dec 2008 12:53:44 GMT

I'm using the VB templates but the same thing occurs in the C# code templatess. The current generators create the following code snippit in the ExcuteFetch method.
Using dr As SafeDataReader = New SafeDataReader(cm.ExecuteReader())
FetchObject(dr)
ValidationRules.CheckRules()

'load child object(s)
FetchChildren(dr)
End Using

I think there are a number of issues with the placement of the ValidationRules.CheckRules() method.
1. The object will be IsDirty=True and IsNew = True when you execute the code so any validation rules the check for Target.IsDirty OrElse Target.IsNew will be incorrect when the CheckRules method runs.
2. If you have more complex business rules that include checks against values in the children object, they are invariably going to fail, but then you get the children data after this method is called, so the businessobject could then be valid.

Recommended changes.
1. Move the ValidationRules.CheckRules() call till after the root/children objects have all been loaded for the business object.
2. Include a MarkOld method prior to calling the ValidationRules.
Eg.
...
Using dr As SafeDataReader = New SafeDataReader(cm.ExecuteReader())
FetchObject(dr)

'load child object(s)
FetchChildren(dr)
End Using
MarkOld()
ValidationRules.CheckRules()
....
Comments: completed! change set 44818

Source code checked in, #44818

RickySupit — Sat, 13 Dec 2008 12:49:23 GMT

workitem:20186 (CS v2.0) Move ValidationRules.CheckRules() after fetch children

Commented Issue: VB Command Template crashed Codesmith.

RickySupit — Sat, 13 Dec 2008 12:27:22 GMT

G'day,

If you try and run the command template you will get the following error.

Template 'Command.cst' is not a business Object template type.
Comments: ** Comment from web user: RickySupit **

Jamie,
I'm not sure if anybody still maintain the VB version. I believe they are not on par with the C# version. Would you like to contribute and make the VB version on par with the C# version?

Ricky