Drawing Custom Borders in Windows Forms

NEW POST: Minimize/Restore with hidden caption bar makes window shrink/grow

santhosh — Tue, 22 Apr 2008 06:17:20 GMT

The same problem exist for all custom drawn forms (my own also) . May be the author of this code fix the problem.
The minimize restore problem exist if height of the caption (by changing client area) is changed. If it is kept as the standard OS height you will not get this issue.

COMMENTED ISSUE: MDI support

BillKrat — Wed, 30 Jan 2008 00:14:30 GMT

I have no specific issues - I have not tested the code at this time. However, reading the multiple comments on the blog, along with no reply answering them, comes this:

MDI support. Custom border forms should support the effortless switch between MDI and SDI that .net implements for standard forms. Behavior should be identical, and translation of screen coordinates should be automatic (from screen position to clientarea position within the parent). Child forms should be separately skinnable from the parent, and the parent should be skinnable as well.

If this has already been addressed, please notify me (glacialfury@gmail.com) and remove this ticket.

Thank you for this project - I will be reading through it extensively in the coming weeks.

glacialfury
Comments: ** Comment from web user: BillKrat **

I provide a work-around in the Discussion area under the topic "MDI Forms do not work correctly"

NEW POST: MDI Forms do not work correctly

BillKrat — Wed, 30 Jan 2008 00:13:25 GMT

I'm utilizing this work-around with the Smart Client Software Factory (for the Shell and my views)

The problem becomes evident by debugging the OnNonClientAreaHitTest(Point p) - the MDI Parent's button.Bounds will correctly hold it's coordinates but the MDI child will have incorrect values; the x and y coordinates are relative to itself where the received parameter (Point p), that it is compared to, are relative to the MDI Parent.

The workaround that I provide below will allow you to move and close a MDI Child form (these are all I required and time-constraints don't permit me to take it further); in addition, and for the same reason, I hard-coded the values to the stock "VistaForm" skin; you may need to tweak the values in the CompensateForMDI() method.

SkinRenderForm.cs

protected override int OnNonClientAreaHitTest(Point p)
{
    if (ActiveFormSkin == null)
        return (int)NativeMethods.NCHITTEST.HTCLIENT;
 
    foreach (CaptionButton button in this.CaptionButtons)
    {
        if (button.Visible && button.Bounds.Contains(p) && (button.HitTestCode > 0 || button.HitTestCode < -1))
            return button.HitTestCode;
    }

NonClientBaseForm.cs

CompensateForMDI() is a new method and the methods that implement this new method follow below:

protected Point CompensateForMDI(Point p)
{
    bool IsParent = Parent != null;
    if (IsParent)
    {
        p.X -= Parent.Parent.Location.X + 10;
        p.Y -= (Parent.Parent.Location.Y + 75);
    }
    return p;
}
 
 
private void WmNCHitTest(ref Message m)
{
    // http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winui/windowsuserinterface/userinput/mouseinput/mouseinputreference/mouseinputmessages/wm_nchittest.asp
 
    Point screenPoint = CompensateForMDI(new Point(m.LParam.ToInt32()));
 
    Log(MethodInfo.GetCurrentMethod(), string.Format("### Screen Point ({0},{1})", screenPoint.X, screenPoint.Y));
 
    // convert to local coordinates
    Point clientPoint = PointToWindow(screenPoint);
    Log(MethodInfo.GetCurrentMethod(), string.Format("### Client Point ({0},{1})", clientPoint.X, clientPoint.Y));
    m.Result = new System.IntPtr(OnNonClientAreaHitTest(clientPoint));
}
 
private void WmNCMouseMove(ref Message msg)
{
    // http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winui/windowsuserinterface/userinput/mouseinput/mouseinputreference/mouseinputmessages/wm_nchittest.asp
    Point clientPoint = CompensateForMDI(this.PointToWindow(new Point(msg.LParam.ToInt32())));
    OnNonClientMouseMove(new MouseEventArgs(MouseButtons.None, 0,
        clientPoint.X, clientPoint.Y, 0));
    msg.Result = IntPtr.Zero;
}
 
 
private void WmNCLButtonDown(ref Message msg)
{
    Point pt = CompensateForMDI(this.PointToWindow(new Point(msg.LParam.ToInt32())));
    NonClientMouseEventArgs args = new NonClientMouseEventArgs(
        MouseButtons.Left, 1, pt.X, pt.Y, 0, msg.WParam.ToInt32());
    OnNonClientMouseDown(args);
    if (!args.Handled)
    {
        DefWndProc(ref msg);
    }
    msg.Result = NativeMethods.TRUE;
}

SkinRenderForm.cs

The "|| Parent!=null" statement is the only change

protected override void OnNonClientMouseDown(NonClientMouseEventArgs args)
{
    if (args.Button != MouseButtons.Left)
        return;
 
    // custom button
    foreach (CaptionButton button in this.CaptionButtons)
        if (args.HitTest > short.MaxValue && args.HitTest == button.HitTestCode && button.Visible && button.Enabled)
        {
            ((CustomCaptionButton)button).OnClick();
            args.Handled = true;
            return;
        }
 
    // find appropriate button
    foreach (CaptionButton button in this.CaptionButtons)
    {
        // [1530]: Don't execute any action when button is disabled or not visible.
        if (args.HitTest == button.HitTestCode && button.Visible && button.Enabled)
        {
            Log(MethodInfo.GetCurrentMethod(), "MouseDown: button = {0}", button);
 
            if (DepressButton(button) || Parent!=null)
            {

NEW POST: Can I get the compiled dlls?

dawmail333 — Tue, 28 Aug 2007 12:03:30 GMT

I can't compile the dll's with C# Express. Can someone else give me a compiled version?

daw mail 333 (@t) g mail (dOt) com

(Just take out the spaces and replace the words in brackets)

NEW POST: Minimize/Restore with hidden caption bar makes window shrink/grow

joaomaia — Tue, 07 Aug 2007 11:13:20 GMT

Hi, were you able to solve this problem?
Thanks

COMMENTED ISSUE: MDI support

Puppie — Fri, 04 May 2007 14:12:36 GMT

I have no specific issues - I have not tested the code at this time. However, reading the multiple comments on the blog, along with no reply answering them, comes this: MDI support. Custom border forms should support the effortless switch between MDI and SDI that .net implements for standard forms. Behavior should be identical, and translation of screen coordinates should be automatic (from screen position to clientarea position within the parent). Child forms should be separately skinnable from the parent, and the parent should be skinnable as well. If this has already been addressed, please notify me (glacialfury@gmail.com) and remove this ticket. Thank you for this project - I will be reading through it extensively in the coming weeks. glacialfury Comments: ** Comment from web user: Puppie **

A+++ for the code mate - really nice example and showing how things work under the hood... I recently attempted to imcorportate this into an MDI sample to see how it would handle and came across issues where the child form's "skin" was not being picked up correctly and the buttons were not able to be pressed...

Any ETA on when the next release will be out with this incorporated?

NEW POST: Enhancing the performance of the paint method

amitbhandari — Wed, 25 Apr 2007 07:12:45 GMT

Hi!
First of all, thumbs up for such a good work done!!

Now, the only problem which I see is that once there are lot of controls put on the form or the form is minimized, and maximized again and again, i.e., Paint method is raised again and again. The form just goes down.

I just want to discuss whether there is any way we can increase the performance of the Paint method (WndProc otherwise).

COMMENTED ISSUE: Windows Vista compatibility

mynab — Thu, 08 Feb 2007 21:17:58 GMT

Custom Border Form does not work very well in Windows Vista. Comments: ** Comment from web user: mynab **

Hello,

thanks for the fix although we loose the clip siblings option. In my About box where I have a textbox above the custom background, the textbox disappears when hovered...

So I think we need a true Vista compatibility.
Thanks

CREATED ISSUE: Windows Server 2003 Issues

ThomasKaiser — Mon, 08 Jan 2007 19:48:57 GMT

It appears that Windows Server 2003 (Enterprise Edition) has problems rendering the styles. When the program first starts up, the custom style is completely invisible. However, the functionality and buttons still work. (You just can't see it.) It seems that if the window is resized, it will correctly redraw the style. If it is minimized and restored, it will become invisible again. It does not matter whether the Themes service is on or off. It also does not matter if it is done via Remote Desktop.

Developer Forum: Minimize/Restore with hidden caption bar makes window shrink/grow

Hammer — Thu, 21 Dec 2006 08:37:48 GMT

First of all. I just downloaded the source and do not know if this issue has been up here before. But anyhow. Here I go: How to reproduce: Im running XP SP2 - classic mode... 1) I downloaded version 6125 of the source code. 2) Start the Demo sample. 3) Check the "Enable custom borders" checkbox. 4) Minimize the Demo window 5) Restore the Demo window Result: After restoring the window, it's height has increased (compared to when it was minimized). Excpected behaviour: The window should have the same size after it has been restored as it had before being minimized. Notes: The same behaviour exists when the following is done: 1) "Show desktop" (Win+D or Win+M) 2) Restore the Demo window. I now that the same windows messages are not sent in this case compared to the above, but it should behave the same way.

CREATED ISSUE: Minimize/Restore with hidden caption bar makes window shrink/grow

Hammer — Fri, 24 Nov 2006 12:52:01 GMT

Project Management Forum: Pass on to Ascend if you're losing steam

rgardner — Mon, 20 Nov 2006 06:31:01 GMT

I'd love to see this project continue on and if you guys are losing steam could you reconsider passing this project on to the Ascend group? Just a thought.

COMMENTED ISSUE: Windows Vista compatibility

kpfile — Thu, 16 Nov 2006 22:04:23 GMT

Custom Border Form does not work very well in Windows Vista. Comments: ** Comment from web user: kpfile **

I was able to resolve this issue. In the PaintNonClient area function,
//IntPtr hDC = NativeMethods.GetDCEx(hWnd, hRgn,
// (int)(NativeMethods.DCX.DCX_WINDOW | NativeMethods.DCX.DCX_INTERSECTRGN
// | NativeMethods.DCX.DCX_CACHE | NativeMethods.DCX.DCX_CLIPSIBLINGS));

Is called. This function is not working correctly in Windows XP 64 bit or Windows Vista. It will return the null pointer in some cases.

IntPtr hDC = NativeMethods.GetWindowDC(hWnd);
This second call works correctly in all OSes i've tested from Win2k to Vista RC2 64 bit. I'm not quite sure what the problem is, or what I lose by calling it instead, but it works.

(add the following to NativeMethods)
[DllImport("user32.dll")]
public static extern IntPtr GetWindowDC(IntPtr hwnd);

Developer Forum: RE: Use project in VB.NET

evan1979 — Thu, 09 Nov 2006 03:39:07 GMT

Hi CaptnKebec, Is there any chance I could please get a copy of your VB.NET (converted) solution? /evan

Developer Forum: Skining with OpenGL

cdemez — Tue, 24 Oct 2006 09:00:15 GMT

Take a look at : http://www.codeproject.com/useritems/BLACK_BOX_II.asp

Project Management Forum: RE: Next Release

rgardner — Tue, 24 Oct 2006 03:03:06 GMT

you guys still working on this project?

Developer Forum: Bug dragging

dactivo — Wed, 18 Oct 2006 15:50:22 GMT

Hi, everybody: Two things: 1.-I don't know if you have found this problem. When i open a form with a design using the custom borders and i click down and drag one of the buttons (close or minimize...) and then click up outside the button, we can see how the original Framework buttons appear. 2.-Another thing, how can i create the fsl file. Salud, Dactivo http://www.d-activo.com

Developer Forum: New enhancement request

rgardner — Wed, 18 Oct 2006 15:05:48 GMT

Something to consider that would be very useful for us application developers. My application, as I'm sure others, has other details about the "skin" that your tool is not capturing. Things like accent colors, icons, border sizes, etc. What would be really helpful is if you provided a dictionary in your editor that designers could enter in custom name value pairs of properties. And then in your api allow application developers access to those properties by name. This way we could go to one place for skin generation instead of having to code up another specific editor just for those parts that fall outside of your utility. ** It would be even cooler if that collection was typed and the editor did things like chose color or serialized images just as it does with the built-in types. Thanks, good job so far. I hope you guys keep on developing into a release.

User Forum: How to add form like this in the Add New Item dialog?

lulalu — Sat, 14 Oct 2006 14:19:24 GMT

I would like to add/install the skinned form and later i want to have it available from within "Add New Item" dialog(window). Could you write down some instructions how this can be acomplished? Thanks :)

Developer Forum: RE: Use project in VB.NET

CaptnKebec — Tue, 03 Oct 2006 22:51:52 GMT

Yes, converting the entire project in VB instead of mixing C# and VB corrected the problem. I am now experiencing a full "skinable" application!! Thanks