MVC Contrib - MvcContrib.org

Patch Uploaded

Woil — Tue, 13 May 2008 18:23:28 GMT

Woil has uploaded a patch.

Description:
Newer version of the Convention Rescue patch, now merged into RescueAttribute. Includes an update to the ConventionController sample.

[Rescue("DefaultRescue")]
public ActionResult ControllerAction {
throw new CookieException();

//this will look for CookieException.aspx
//then call DefaultRescue.aspx if not found
}

Patch Uploaded

katokay — Mon, 12 May 2008 17:25:18 GMT

katokay has uploaded a patch.

Description:
This patch has two parts.

Updated dll's for release version of Unity.

Fixed bug for NameValueDeserializer cyclical reference bug. This will also prevent the instantiation of objects that are not part of the request.

Patch Uploaded

Woil — Fri, 09 May 2008 23:43:39 GMT

Woil has uploaded a patch.

Description:
Adds ConventionRescueAttribute, providing ability to switch to different rescue views depending on what type of exception is thrown. If a matching view is not found it will use the rescue provided in the attribute. Exception types can also be provided which will force only those types of exceptions to be grabbed by this view. This prevents the need for multiple attributes in front of every class/method that needs routing depending on the exception thrown.

[ConventionRescue("DefaultRescue")]
public ActionResult ControllerAction {
throw new CookieException();

//this will look for CookieException.aspx
//then call DefaultRescue if not found
}

Patch Uploaded

markhildreth — Thu, 08 May 2008 03:49:49 GMT

markhildreth has uploaded a patch.

Description:
When using a strongly-typed view, many of my tests include checking that the view rendered was passed correct data. It may be a few lines to assert that the type is itself correct before casting to the correct type to check that the underlying values are correct. This patch makes a method that replaces needing to do this...

var result = controller.Run().AssertViewRendered();
Assert.That(result.ViewData, Is.Type(typeof(MyCustomData), "Expected view data of type 'MyCustomData', actual: '{0}'", typeof(result.ViewData));
var myCustomType = result.ViewData as MyCustomData;
Assert.That(myCustomType, ...)

....with this...
var myCustomType= controller.Run().AssertViewRendered().WithViewData<MyCustomType>();
Assert.That(myCustomType, ...)

Patch Uploaded

stevenr12 — Wed, 07 May 2008 06:07:47 GMT

stevenr12 has uploaded a patch.

Description:
Removing external dependencies from the domain model in the Ninject sample.

Patch Applied

JeremyS — Tue, 06 May 2008 16:28:20 GMT

JeremyS has applied patch #1179.

Comment:
Applied in revision 353.

Patch Uploaded

timtas — Mon, 05 May 2008 18:27:45 GMT

timtas has uploaded a patch.

Description:
This patch primarily enhances the NameValueDeserializer to handle cases when a key has multiple values. Consider when a select control with multiple selections. Before this enhancement, this key would be treated as one simple value in the form of a comma separated string. It makes more sense to first try to match this with a a simple array list proprty. I believe that this a common scenario, and therefore I am submitting a patch. This patch includes some other fixes and enhancements in related areas. Here are the details:

1) Support deserializing multi-value keys to simple array list properties.
2) Fix bug where individual checkbox controls are not deserialized properly
3) Fix Select<T> problem whereby options are ordered haphazardly instead of by enum value
4) Add support to Select -- can set selected values of from complex types
5) Add support to Select -- can set "selectedValue" attribute as complex type and/or collection
6) Interpret a selected value of null as and empty string (instead of doing nothing). This is useful in conjunction with the firstOption feature

I have also added test to cover these features.

Patch Declined

JeremyS — Mon, 05 May 2008 10:47:00 GMT

JeremyS has declined patch #1101.

Comment:
This would be too much of a breaking change. However, it should be possible to work around the issue. See http://groups.google.com/group/mvccontrib-discuss/browse_thread/thread/61e2b46c53486a22

Patch Applied

JeremyS — Mon, 05 May 2008 10:46:17 GMT

JeremyS has applied patch #1141.

Comment:
Applied in revision 349.

Patch Applied

JeremyS — Mon, 05 May 2008 10:25:48 GMT

JeremyS has applied patch #1128.

Comment:
Applied in revision 347. However, a better approach to automatically set the ViewEngine is to use Windsor's Setter Injection support.

Patch Declined

JeremyS — Mon, 05 May 2008 10:21:20 GMT

JeremyS has declined patch #1142.

Comment:
The same result can be achieved using filters as discussed at http://groups.google.com/group/mvccontrib-discuss/browse_thread/thread/61e2b46c53486a22

Patch Applied

JeremyS — Mon, 05 May 2008 10:19:10 GMT

JeremyS has applied patch #1168.

Comment:
Applied in revision 345.

Patch Applied

JeremyS — Sat, 03 May 2008 17:05:29 GMT

JeremyS has applied patch #1162.

Comment:
Applied with modifications in revision 343.

Patch Applied

JeremyS — Sat, 03 May 2008 15:07:21 GMT

JeremyS has applied patch #1158.

Comment:
Applied in revision 341.

Patch Uploaded

CVertex — Sat, 03 May 2008 06:40:04 GMT

CVertex has uploaded a patch.

Description:
Phil Haack wrote a url routing debugger I think is invaluable for learning about routes and debugging them.
See http://haacked.com/archive/2008/03/13/url-routing-debugger.aspx

This patch is the 4 core files of haack's code unchanged except for a namespace change to MvcContrib.Routing

Hope Phil doesn't mind me putting it here.

Patch Uploaded

timtas — Wed, 30 Apr 2008 19:24:32 GMT

timtas has uploaded a patch.

Description:
I found that Html.Form().Select does not naturally support enumerations. I want to populate selects with enum values and then set selected items using enum arrays. Also, I found that it does not support setting selected values of multi-selects. To accomplish these two items, I created overrides like:

Html.Form().Select<Color>("myEnum")
Html.Form().Select<Color>("myEnum", new Hash(firstOption => "Choose", firstOptionValue => "")

...where Color is an enum. The latter will render a select with options:

<option value="">Choose</option>
<option value="0">Red</option>
<option value="1">Blue</option>
<option value="2">Green</option>

Further, I added support to all overrides of Select for selecting multiple options. This can be done in two ways. First, using the method:

Html.Form().Select<Color>("myEnum", new Hash(selectedValue => new Color[] { Color.Red, Color.Green }))

Second, using a view data entry matching the select name:

ViewData["myEnum"] = new Color[] { Color.Red, Color.Green };

To see how the code works, look at these new tests in When_Select_Is_Invoked class:

With_generic_enum_parameter_the_correct_html_is_generated
With_generic_enum_parameter__and_firstoption_and_selected_the_correct_html_is_generated
With_generic_enum_parameter_and_the_name_matches_an_item_in_the_ViewData_it_should_be_databound

CREATED ISSUE: Databind support Castle ActiveRecord class

jcclementoni — Wed, 30 Apr 2008 04:02:39 GMT

I am trying use Deserialize attribute from MvcContrib.Attributes.DeserializeAttribute with a Castle ActiveRecord class. Something like this:

public ActionResult Create([Deserialize("DocumentoCliente")] DocumentoCliente documentoCliente)

I get cannot create instance error.

This error is because MvcContrib.NameValueDeserializer.CreateInstance try create a IDictionary instance from PropertiesValidationErrorMessage of ActiveRecordValidationBase class.

I upload screenshot error for more details

I fix inserting a new if in NameValueDeserializer.Deserialize() method:

if(IsSimpleProperty(propertyType))
{
string sValue = collection.Get(name);
if(sValue != null)
{
SetValue(instance, property, GetConvertible(sValue));
}
}
else if(propertyType.IsArray)
{
Type elementType = propertyType.GetElementType();

ArrayList arrayInstance = DeserializeArrayList(collection, name, elementType);

SetValue(instance, property, arrayInstance.ToArray(elementType));
}
else if(IsGenericList(propertyType))
{
IList genericListProperty = GetGenericListProperty(instance, property);

if(genericListProperty == null) continue;

DeserializeGenericList(collection, name, propertyType, ref genericListProperty);
}
else if (((System.Reflection.MemberInfo)(property)).Name.Equals("PropertiesValidationErrorMessage"))
{
// Castle Active Record support.. do nothing
}
else
{
object complexProperty = GetComplexProperty(instance, property);

if (complexProperty == null) continue;

Deserialize(collection, name, propertyType, ref complexProperty);
}

I dont know if this is the best solution for this problem.

What we can do?

Thanks and Sorry for my poor english,

João Carlos Clementoni

Patch Uploaded

joshuaflanagan — Tue, 29 Apr 2008 15:23:23 GMT

joshuaflanagan has uploaded a patch.

Description:
Extends the ActionResultHelper to allow you to specify a strongly typed (resharperable) controller and action for ActionRedirectResults.

Allows:
controller.Index().AssertIsActionRedirect().ToAction<HomeController>(c => c.About())
instead of:
controller.Index().AssertIsActionRedirect().ToController("Home").ToAction("about")

COMMENTED TASK: Restful Routing Sample App

kevin_ortman — Mon, 28 Apr 2008 05:24:20 GMT

Build a sample application showing off restful routing.
Comments: ** Comment from web user: kevin_ortman **

BTW... I documented this sample here: http://kevinortman.blogspot.com/2008/04/simplyrestfulroutehandler-sample.html

COMMENTED TASK: Restful Routing Sample App

kevin_ortman — Mon, 28 Apr 2008 03:22:56 GMT

Build a sample application showing off restful routing.
Comments: ** Comment from web user: kevin_ortman **

You are welcome to use this sample app. It was build using:
MVC 0416 (4/16/08)
MVCContrib 0.0.1.101 (4/19/08)

It's a super-simple example that shows all 8 actions.