Wintellect's Power Collections for .NET

NEW POST: Distributing a refactored version

slorion — Fri, 16 May 2008 10:16:33 GMT

I am working on a commercial library project where PowerCollections is used as an utility library (ie, it is not the main feature). That said, I would still like to expose it publicly as a convenience. What I would like to know for sure is if I can refactor PowerCollections (e.g. split Algorithms class in smaller parts, change the namespace/class/method names, etc.) and distribute said modifications, both in binary and source form, given that I include the original license and copyright notices, and clearly annotate where I modified the original source code. Reading the EPL, I am guessing the answer is yes, but I would like a confirmation of that as I am not 100% sure. Thank you.

CREATED ISSUE: Pair should not implement IComparable, should implement IEquatable

okoboji — Sun, 09 Mar 2008 05:05:19 GMT

The current IComparable implementation throws if the contained types fail to implement IComparable, which I believe to be a bad design (if that's the case, the argument should be required to implement IComparable)

It may be a good idea, though, to have Pair implement IEquatable<>, since Equals(Pair<TFirst, TSecond> other) already exists.

CREATED ISSUE: MultiDictionary Remove and RemoveMany bug

MelindaYoung — Tue, 19 Feb 2008 15:38:05 GMT

If you try to remove an item from a MultiDictionary when it doesn't exist and there is only one element in the MultiDictionary, the last element is removed. See code snippet below:

MultiDictionary<string, int> lMultiDictionary = new MultiDictionary<string, int>(false);
lMultiDictionary.Add("key", 1);
lMultiDictionary.Remove("key", 2);

If this code is executed the MultiDictionary will no longer contain any values for "key".

From the PowerCollections source code in MultiDictionary::Remove(TKey key, TValue value)
{
...
if (existingCount == 1) { //***** There is no check here for indexFound >= 0********
// Removing the last value. Remove the key.
hash.Delete(existing, out keyValues);
return true;
}
else if (indexFound >= 0) {
// Found a value. Remove it.
if (indexFound < existingCount - 1)
Array.Copy(existing.Values, indexFound + 1, existing.Values, indexFound, existingCount - indexFound - 1);
existing.Count = existingCount - 1;

// Update the hash.
hash.Find(existing, true, out keyValues);
return true;
}
else {
// Value was not found.
return false;
}
...
}

NEW POST: .NET Compact Framework 2.0 support

wizrr — Tue, 22 Jan 2008 09:57:34 GMT

Hi.

I used Wintellect's Power Collections for my .NET CF projects (recompiled against .NET CF 2.0 without Serializable attribute and replaced just one native call with same implementation for .NET CF). I can provide source code changes for it (paths). If somebody plans to official .NET CF 2.0 support for library where i can send paths?

Best regards,
Zaripov Rinat .

COMMENTED ISSUE: Empty Set<> serialization bug

MihaMarkic — Sun, 23 Dec 2007 20:44:16 GMT

This sample crashes then the Set is empty.

new BinaryFormatter().Serialize(new MemoryStream(), new Set<int>());
Comments: ** Comment from web user: MihaMarkic **

Duh, I see that fix is already posted :-)

COMMENTED ISSUE: Empty Set<> serialization bug

MihaMarkic — Sun, 23 Dec 2007 20:43:08 GMT

This sample crashes then the Set is empty.

new BinaryFormatter().Serialize(new MemoryStream(), new Set<int>());
Comments: ** Comment from web user: MihaMarkic **

Here is the fixed code if anybody is interested:
void IDeserializationCallback.OnDeserialization(object sender)
{
if (serializationInfo == null)
return;

loadFactor = serializationInfo.GetSingle("loadFactor");
equalityComparer = (IEqualityComparer<T>) serializationInfo.GetValue("equalityComparer", typeof(IEqualityComparer<T>));

T[] items = (T[])serializationInfo.GetValue("items", typeof(T[]));
if (items != null)
{
T dummy;

EnsureEnoughSlots(items.Length);
foreach (T item in items)
Insert(item, true, out dummy);
}

serializationInfo = null;
}

void ISerializable.GetObjectData(SerializationInfo info, StreamingContext context)
{
if (info == null)
throw new ArgumentNullException("info");

info.AddValue("equalityComparer", equalityComparer, typeof(IEqualityComparer<T>));
info.AddValue("loadFactor", loadFactor, typeof(float));
T[] items = new T[count];
int i = 0;
if (table != null)
{
foreach (Slot slot in table)
if (!slot.Empty)
items[i++] = slot.item;
info.AddValue("items", items, typeof(T[]));
}
else
info.AddValue("items", null, typeof(T[]));
}

NEW POST: Using Power Collections in .Net 1.1

granadaCoder — Thu, 20 Dec 2007 22:15:14 GMT

The library uses Generics,and Generics is a 2.0 only feature.

It's (almost) 2008, and the move to 2.0 should be in your near future.

Good luck.

NEW POST: Install

granadaCoder — Thu, 20 Dec 2007 22:14:11 GMT

No...

The zip file contains
\PowerCollections\Binaries\PowerCollections.dll

You simply go to your .Net project..do a "Add Reference", and browse to this file. Then click "Add".

Now you can use it. It will (most likely) be copied to your /bin/Debug/ folder when you build your application.

Good luck.

NEW POST: Xml [Serializable] ?

granadaCoder — Thu, 20 Dec 2007 22:03:06 GMT

Are there any plans to make the collections Xml Serializable friendly?
I've encounted this issue with the MultiDictionary object.

One of the obstacles...is the lack of default constructors. Here is one I tried to implement.

public MultiDictionary()
: this(true, EqualityComparer<TKey>.Default, EqualityComparer<TValue>.Default)
{
//I picked "true" for allow duplicates.....
}

I attempted this inclusion...and it helped.

What's getting me is the implementation of a ..Default Accessor Implementation..
I have to admit, my Generic(s) skills are average at best.

But something like this is apparently missing. Here is where I got stuck.

public Something?? thisint index
{
get
set
}

I tried a couple of different things...but either my lack of ability with generics or not discerning the concrete or base object correctly is hindering me.

Here is my test object ... which I can create...but I get the issues when I try to serialize it to Xml.

Serializable
public class PowerCollectionMultiDictionaryTestWrapperForXml
{
private string _name = string.Empty;
public string Name
{
get { return _name; }
set { _name = value; }
}

private int _age = 0;
public int Age
{
get { return _age; }
set { _age = value; }
}

Wintellect.PowerCollections.MultiDictionary<Guid, Guid> _doubleGuidMultiDictionary = new Wintellect.PowerCollections.MultiDictionary<Guid, Guid>(true);

public Wintellect.PowerCollections.MultiDictionary<Guid, Guid> DoubleGuidMultiDictionary
{
get { return _doubleGuidMultiDictionary; }
set { _doubleGuidMultiDictionary = value; }
}
}

//and code to instantiate
PowerCollectionMultiDictionaryTestWrapperForXml pct = new PowerCollectionMultiDictionaryTestWrapperForXml();
pct.Name = "Sloan";
pct.Age = 35;
pct.DoubleGuidMultiDictionary.Add(Guid.NewGuid(), Guid.NewGuid());

I'll continue to work on it..but thought I'd at least list out the issue.

Since the code is:

Serializable
public class MultiDictionary<TKey, TValue> : MultiDictionaryBase<TKey, TValue>, ICloneable
{}

The intent definately looks to be "Make it Serializable".

Thanks.

NEW POST: Install

GiJeet — Wed, 19 Dec 2007 18:21:04 GMT

Hello, I'm a newbie to .net, do I need to register PowerCollections.dll using regsvr32 to be able to use this collection? Please advise on install procedure. Thanks.

Gi

COMMENTED ISSUE: Bug in MultiDictionary: RemoveAll throws InvalidOperationException: Collection was modified during an enumeration.

nokiola — Sat, 01 Dec 2007 19:59:26 GMT

The following snippet shows that RemoveAll throws InvalidOperationException: Collection was modified during an enumeration.

using System;
using System.Collections.Generic;
using Wintellect.PowerCollections;

namespace TestPowerCollections
{
class Program
{
static readonly MultiDictionary<int, int> list = new MultiDictionary<int, int>(false);
static void Main(string[] args)
{
for (int i = 0; i < 100000; i++)
list.Add(i, i);

ICollection<KeyValuePair<int, ICollection<int>>> removed = list.RemoveAll(delegate(KeyValuePair<int, ICollection<int>> obj)
{
return true;
});

Console.WriteLine("Removed: " + removed.Count);
Console.WriteLine("Remaining: " + list.Count);

Console.ReadLine();
}

}
}
Comments: ** Comment from web user: nokiola **

at Wintellect.PowerCollections.Hash`1.CheckEnumerationStamp(Int32 startStamp)
at Wintellect.PowerCollections.MultiDictionary`2.<EnumerateValues>d__1a.MoveNext()
at Wintellect.PowerCollections.MultiDictionaryBase`2.RemoveMany(TKey key, IEnumerable`1 values)
at Wintellect.PowerCollections.MultiDictionaryBase`2.Remove(KeyValuePair`2 pair)
at Wintellect.PowerCollections.Algorithms.RemoveWhere[T](ICollection`1 collection, Predicate`1 predicate)
at Wintellect.PowerCollections.CollectionBase`1.RemoveAll(Predicate`1 predicate)
at TestPowerCollections.Program.Main(String[] args) in C:\Users\Robert\Documents\Visual Studio 2008\Projects\TestPowerCollections\TestPowerCollections\Program.cs:line 15

CREATED ISSUE: Bug in MultiDictionary: RemoveAll throws InvalidOperationException: Collection was modified during an enumeration.

nokiola — Sat, 01 Dec 2007 19:57:17 GMT

NEW POST: Using Power Collections in .Net 1.1

satishshindein — Fri, 16 Nov 2007 06:46:15 GMT

Hi,

I want to use power collections but since the existing applications are using .net framework 1.1, i cannot use .net framework 2.0
Please suggest some workaround for the same.
AWAITING UR REPLY!!!

Regards,

Satish

CREATED ISSUE: Still one problem in unit tests

kradewald — Fri, 26 Oct 2007 11:57:28 GMT

I encountered one left ofter issue with the unit tests, AlgorithmTests.cs, line 4331:

NUnit.Framework.AssertionException: String lengths are both 22. Strings differ at index 19.
Expected: "{hello,8,{1,2,3},-8,9}"
But was: "{hello,8,{1,2,3},-8.9}"
------------------------------^

I would propose to explicitly use InvariantCulture for such things.

Patch Uploaded

LaurentGRATEAU — Fri, 26 Oct 2007 04:59:09 GMT

LaurentGRATEAU has uploaded a patch.

Description:
This file fix the Issue 1704. Test could be added to cover this issue.

COMMENTED ISSUE: Empty Set<> serialization bug

lolofresnes — Thu, 25 Oct 2007 14:15:55 GMT

This sample crashes then the Set is empty.

new BinaryFormatter().Serialize(new MemoryStream(), new Set<int>());
Comments: ** Comment from web user: lolofresnes **

Replace the attached file to fix this issue.

CREATED ISSUE: MultiDictionary Serialization issue when empty

Bram — Sun, 07 Oct 2007 22:29:56 GMT

The following stacktrace occurs when trying to serialize an empty MultiDictionary:

at Wintellect.PowerCollections.Hash`1.System.Runtime.Serialization.ISerializable.GetObjectData(SerializationInfo info, StreamingContext context) in E:\PowerCollections-6259\Source\PowerCollections\Hash.cs:line 617
at System.Runtime.Serialization.Formatters.Binary.WriteObjectInfo.InitSerialize(Object obj, ISurrogateSelector surrogateSelector, StreamingContext context, SerObjectInfoInit serObjectInfoInit, IFormatterConverter converter, ObjectWriter objectWriter)
at System.Runtime.Serialization.Formatters.Binary.WriteObjectInfo.Serialize(Object obj, ISurrogateSelector surrogateSelector, StreamingContext context, SerObjectInfoInit serObjectInfoInit, IFormatterConverter converter, ObjectWriter objectWriter)
at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.Write(WriteObjectInfo objectInfo, NameInfo memberNameInfo, NameInfo typeNameInfo)
at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.Serialize(Object graph, Header[] inHeaders, __BinaryWriter serWriter, Boolean fCheck)
at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Serialize(Stream serializationStream, Object graph, Header[] headers, Boolean fCheck)
at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Serialize(Stream serializationStream, Object graph)
at Wintellect.PowerCollections.Tests.InterfaceTests.SerializeRoundTrip(Object objToSerialize) in E:\PowerCollections-6259\Source\UnitTestsVSTS\InterfaceTests.cs:line 1707
at Wintellect.PowerCollections.Tests.MultiDictionaryTests.SerializeEmpty() in E:\PowerCollections-6259\Source\UnitTestsVSTS\MultiDictionaryTests.cs:line 1240

I have reproduced this by using the following TestMethod on MultiDictionaryTests:
[TestMethod]
public void SerializeEmpty()
{
MultiDictionary<string,double> d = new MultiDictionary<string,double>(true);

MultiDictionary<string, double> result = (MultiDictionary<string, double>)InterfaceTests.SerializeRoundTrip(d);
}

Seems that "private Hash<KeyAndValues> hash;" isn't initialized.

CREATED ISSUE: Empty Set<> serialization bug

Morty — Wed, 03 Oct 2007 16:27:53 GMT

This sample crashes then the Set is empty.

new BinaryFormatter().Serialize(new MemoryStream(), new Set<int>());

CLOSED ISSUE: Bad help file on site

rogerdahlman — Sun, 09 Sep 2007 03:23:31 GMT

The help file that is available for download (PowerCollections.chm) is non-functional. It appears that all of the links are wrong and have a machine name user id with them.
Comments: I generated a new help file with Sand Castle and this has fixed the problems. The old file was generated with a version on NDOC that did not work correctly with the 2.0 framework.

UPDATED RELEASE: Initial Wintellect Codebase (Nov 11, 2005)

Sun, 09 Sep 2007 03:20:23 GMT

This release consists of the source and binaries that were previously available from [url:http://www.wintellect.com]. It is the baseline for future development.

Wintellect's Power Collections for .NET

NEW POST: Distributing a refactored version

CREATED ISSUE: Pair should *not* implement IComparable, should implement IEquatable

CREATED ISSUE: MultiDictionary Remove and RemoveMany bug

NEW POST: .NET Compact Framework 2.0 support

COMMENTED ISSUE: Empty Set<> serialization bug

COMMENTED ISSUE: Empty Set<> serialization bug

NEW POST: Using Power Collections in .Net 1.1

NEW POST: Install

NEW POST: Xml [Serializable] ?

NEW POST: Install

COMMENTED ISSUE: Bug in MultiDictionary: RemoveAll throws InvalidOperationException: Collection was modified during an enumeration.

CREATED ISSUE: Bug in MultiDictionary: RemoveAll throws InvalidOperationException: Collection was modified during an enumeration.

NEW POST: Using Power Collections in .Net 1.1

CREATED ISSUE: Still one problem in unit tests

Patch Uploaded

COMMENTED ISSUE: Empty Set<> serialization bug

CREATED ISSUE: MultiDictionary Serialization issue when empty

CREATED ISSUE: Empty Set<> serialization bug

CLOSED ISSUE: Bad help file on site

UPDATED RELEASE: Initial Wintellect Codebase (Nov 11, 2005)

CREATED ISSUE: Pair should not implement IComparable, should implement IEquatable