TeamReview

New Post: Press on TeamReview

JBBrown — Tue, 26 Aug 2008 05:46:15 GMT

From Willy-Peter Schaub (VSTS MVP) - http://dotnet.org.za/willy/archive/2008/08/25/teamreview-take-a-look-at-this-product.aspx

Commented Issue: Replay highlighting not wroking

JBBrown — Sat, 23 Aug 2008 01:18:18 GMT

Using 1.0.5 in VS2005, we are able to create code review response items, but their code snippet tabs are empty. When we come to play back the responses, when we select an item in the replay window, the code associated with it is not highlighted in the main code window.

Thanks

Colin
Comments: ** Comment from web user: JBBrown **

waiting on user experience of release 1.0.6 to see if this is resolved.

Commented Feature: Iteration of Response should equal iteration of review

JBBrown — Sat, 23 Aug 2008 01:17:42 GMT

see this discussion thread: http://www.codeplex.com/Thread/View.aspx?ProjectName=TeamReview&ThreadId=32726
Comments: ** Comment from web user: JBBrown **

Waiting on user experience of Release 1.0.6 to see if this is resolved or not

New Post: Should Iteration of Response = Iteration of Review

JBBrown — Sat, 23 Aug 2008 01:13:49 GMT

For those that reach this thread - This idea was included in release 1.0.6

Thanks,
JB

New Post: Assign To: not getting populated

_Trip — Fri, 22 Aug 2008 14:06:43 GMT

Sorry All - totally my bad. Looks like I didn't have *any* users in the contributers groups that was being read by the add-in.

Once I added the users in the proper groups - everything populated and it is working great!

Thanks for the replies, sorry for the wasted time...

-Tim

New Post: Assign To: not getting populated

JBBrown — Fri, 22 Aug 2008 02:33:11 GMT

This is a tough one. Theoretically the assign to drop down should be populated with all users in the Contributors and Project Administrators groups; assuming that I am using the Team System API correctly. Have you debugged an Add-In before? Would you be willing to try? I've linked to directions how to debug TeamReview below, and I'd be willing to walk you through it any way that you'd like. This bug seems situational; and I haven't been able to recreate that situation.

Debug directions: http://www.codeplex.com/TeamReview/Thread/View.aspx?ThreadId=26814

You'll need to uninstall TeamReview first.

I very much appreciate that you've posted what you've been able to find so far.
JB

Updated Release: Release 1.0.6 (Aug 21, 2008)

Thu, 21 Aug 2008 21:05:29 GMT

Release Goal

This is a bug fix and minor enhancement release. Note: 1 work item was resolved by changing the Work Item Type definition. It will need to be re-imported and is backwards compatible with previously submitted work items.

Release Features

Features are covered in the resolved work items.

Release Download

Includes Vs.Net AddIn installer and "Code Review Response" work item type definition. For TFS Project setup see: https://www.codeplex.com/Thread/View.aspx?ProjectName=TeamReview&ThreadId=25834

Released: Release 1.0.6 (Aug 21, 2008)

Thu, 21 Aug 2008 21:05:29 GMT

Release Goal

Release Features

Features are covered in the resolved work items.

Release Download

Includes Vs.Net AddIn installer and "Code Review Response" work item type definition. For TFS Project setup see: https://www.codeplex.com/Thread/View.aspx?ProjectName=TeamReview&ThreadId=25834

Updated Wiki: Home

JBBrown — Thu, 21 Aug 2008 21:04:47 GMT

TeamReview by Example

Jane Coder submits a request to review code by entering a new Task and assigning it to Joe CodeReviewer

Then in the IDE Joe CodeReviewer right clicks and uses the TeamReview menu

In the New Code Review Response form Joe selects a Team Query to find Jane's request and then fills out the information and assigns the new Code Review Response to Jane. Note here that the Title is pre-filled by TeamReview

Joe finds another contentious point and uses TeamReview again. This time TeamReview pre-populates the "Query From", "Associate With", and "Assign To" values using the information from the last time.

When Joe is done submitting feedback he re-assigns the original review request from Jane back to her (not shown). Now the review is over and the original code author, Jane, wants to see what feedback was given. She uses the "Code Review Replay" option of TeamReview

The Code Review Replay window comes up and Jane chooses a Team Query to identify her original review request.

Jane starts replaying Joe's feedback by selecting each row in the grid one-by-one, and as she does TeamReview re-opens and re-highlights the section of code Joe originally noted as having an issue.

Jane fixes the code from Joe's feedback and then wants to close the Code Review Response, so she double-clicks in the Code Review Replay Window to open the Work Item.

Of course all of this works because TFS is being used in the background. Here's what Jane's original request looks like with the linked Code Review Response items.

And here is what the Code Details tab of one of those items, Joe's feedback, looks like - with all the code heuristic details available for querying and reporting by TFS or SQL Reporting Services.

New Business Value From Code Review

TeamReview exploits the advantages of Team System and the Vs.net extensibility model to reduce transition waste and surface new value from the code review process. Using Work Items to facilitate the code review process creates a completely in-IDE code review experience, the ability to project-manage the code review tasks, and the opportunity to get new value from the code review process through code review forensics.

For more on the business value of TeamReview view: http://jb-brown.blogspot.com/2008/06/teamreview-new-business-value-from-code.html

TeamReview Advantages

No/less code review meetings necessary
Same place/Same time obstacles are overcome
Makes code review analytics/forensics possible
Easier to split up code reviews both over time and to many people
Accountability - can easily determine if any review feedback was submitted and if that feedback was implemented
Ability to create predefined in-IDE code walk-throughs by any developer on your project without requiring your attendance

TeamReview Press

What other people think about TeamReview - https://www.codeplex.com/Thread/View.aspx?ProjectName=TeamReview&ThreadId=26947

Closed Issue: Enter button in New Code Review Response fields submits the form

JBBrown — Thu, 21 Aug 2008 21:02:03 GMT

The enter button should not submit the form

Closed Issue: Fix "My...." queries to return values