SubSonic: All your database are belong to us

COMMENTED ISSUE: DB.Update() Does Not Set IsLoaded="true"

erickemp — Wed, 14 May 2008 19:30:50 GMT

The issue is that the isloaded flag is not set after an insert and therefore subsequent database calls get no dirty columns.
Comments: ** Comment from web user: erickemp **

Sorry about that... Looks like I reverted some changes prior to check-in... This should REALLY be fixed in Revision 442.

COMMENTED ISSUE: DB.Update() Does Not Set IsLoaded="true" (Patch)

erickemp — Wed, 14 May 2008 19:29:34 GMT

Problems similar to this: http://forums.subsonicproject.com/forums/t/3100.aspx?PageIndex=2

There is a unit test in the attached patch that replicates the problem (as long as the patch to SubSonicRepository isn't applied), basically SubSonicRepository.Update/Save doesn't check item.IsDirty so generates and tries to execute invalid SQL resulting in an "incorrect syntax near the keyword 'WHERE'" error. This happens when:

a) The object hasn't been changed
b) The object doesn't have any "magic" columns such as ModifiedOn etc.

Applied against r441
Comments: ** Comment from web user: erickemp **

Thanks for the patch! Applied in Revision 442.

COMMENTED ISSUE: QuickTable Improperly Qualifies Column Names When Where Clauses are Used

erickemp — Wed, 14 May 2008 17:20:22 GMT

Upgrading from 2.1 beta 1 to beta 3 caused where clauses on my quicktables to fail with the following error :

The multi-part identifier "dbo.columnName" could not be bound.

This would appear to be due to a change made for Issue 15984

The attached patch solved the problem for me.
Comments: ** Comment from web user: erickemp **

Fixed in Revision 432.

CREATED ISSUE: PATCH: SubSonicRepository.Update on non-modified object

smason — Wed, 14 May 2008 16:19:16 GMT

COMMENTED ISSUE: DB.Update() Does Not Set IsLoaded="true"

robsworld2006 — Wed, 14 May 2008 09:29:52 GMT

The issue is that the isloaded flag is not set after an insert and therefore subsequent database calls get no dirty columns.
Comments: ** Comment from web user: robsworld2006 **

I'm not sure if this is really fixed still

DB.Update doesn't seem to work properly
This no longer works, it used to work but no longer works
Member m = new Member();
m.IsLoaded=true;
m.IsNew=false;
m.FirstName="Joe";
DB.Update<Member>(m);

always returns 0 for me

Regards DotnetShadow

COMMENTED ISSUE: QuickTable Improperly Qualifies Column Names When Where Clauses are Used

seedy — Tue, 13 May 2008 21:04:26 GMT

I've just tested it with Rev. 441 and it seems to be working fine eric.

CREATED ISSUE: MySql Connector 5.2.2.0 Updates and some related bug fixes

ncichris — Tue, 13 May 2008 12:00:00 GMT

I have updated Subsonic to support the latest MySql connector client (5.2.2). The main difference is that the parameter marker is changed (or is prefered to be) the @ sign and not the ?. The code uses the @ sign hardcoded, maybe this should become a parameter or something but I do not have the time to do it right now.
Anyway more importantly the patch has some fixes relating to in/out parameters of stored procedures a fix for the calendar control relating to the greek culture, some fixes relating to the unsigned data types, a fix related to having a primary key called id, etc.

COMMENTED ISSUE: Problem updating a RepositoryRecord that has just been added

erickemp — Mon, 12 May 2008 19:52:23 GMT

When using the RepositoryRecord templates it is not possible to insert a new record and then update a field:
RecordType r = new RecordType();
r.Field1 = "val1";
r.Field2 = "val2";
DB.Save(r);
r.Field2 = "new val 2";
DB.Save(r): // This will not update Field2 in the database

I think the problem is in RecordBase.cs line 311:
/// <summary>
/// Sets a value for a particular column in the record
/// </summary>
/// <param name="columnName">Name of the column, as defined in the database</param>
/// <param name="oValue">The value to set the type to</param>
public void SetColumnValue(string columnName, object oValue)
{
columnSettings = columnSettings ?? new TableSchema.TableColumnSettingCollection();
//add the column to the DirtyColumns
//if this instance has already been loaded
//and this is a change to existing values
if(IsLoaded && !IsNew) // Shouldn't this be: if(IsLoaded || !IsNew)
{
TableSchema.Table schema = GetSchema();
object oldValue = null;
string oldValueMsg = "NULL";
string newValueMsg = "NULL";
bool areEqualOrBothNull = false;

Regards,
Stefan
Comments: ** Comment from web user: erickemp **

See: http://www.codeplex.com/subsonic/WorkItem/View.aspx?WorkItemId=16468
Fixed in Rev. 439

CLOSED ISSUE: Scaffold Problem: Operand type clash: uniqueidentifier is incompatible with int

erickemp — Mon, 12 May 2008 19:47:33 GMT

Hi there,

I just tried using the scaffold control and noticed a bug with foreign key being a guid I have posted here:
http://forums.subsonicproject.com/forums/p/3200/13276.aspx#13276

The bug is similar to the one that was fixed here, but I noticed in the latest svn that code doesn't exist anymore
http://www.codeplex.com/subsonic/WorkItem/View.aspx?WorkItemId=14377

Regards DotnetShadow
Comments: Closed per submitter's request...

COMMENTED ISSUE: Where() Operations on Collections Do Not Support Comparision.In and Comparison.NotIn

erickemp — Mon, 12 May 2008 19:46:43 GMT

When Querying a ViewCollection with Comparision.In operation, it act as a Comparision.Equal

following is my code!

string cusid = "";
for (int i = 0; i < cusCol.Count; i++)
{
cusid += cusCol[i].CustomerId + ",";
}
if (!string.IsNullOrEmpty(cusid))
cusid = cusid.Substring(0, cusid.Length - 1);
col.Where(StyleDetailView.Columns.Customer, Comparison.In, cusid);

the sql that generated

/* GetSelectSql(cos_ProductionView) */ SELECT TOP 100 PERCENT [dbo].[cos_ProductionView].[Customer], [dbo].[cos_ProductionView].[Style_NO], [dbo].[cos_ProductionView].[StyleNOIssued], [dbo].[cos_ProductionView].[PO], [dbo].[cos_ProductionView].[PO_Sent], [dbo].[cos_ProductionView].[ActualSupplier], [dbo].[cos_ProductionView].[ActualFobOrCmtPrice], [dbo].[cos_ProductionView].[ActualFobOrCmtPriceConfirmed], [dbo].[cos_ProductionView].[FobOrCmt], [dbo].[cos_ProductionView].[MainFabricCode], [dbo].[cos_ProductionView].[FtyRecFabDate], [dbo].[cos_ProductionView].[ETA_FabricDate], [dbo].[cos_ProductionView].[SpecialTrimOrEmbellish], [dbo].[cos_ProductionView].[Patt_DueDate], [dbo].[cos_ProductionView].[SelfYield], [dbo].[cos_ProductionView].[ActualSelfYield], [dbo].[cos_ProductionView].[FtyProductionYield], [dbo].[cos_ProductionView].[ContrastYield], [dbo].[cos_ProductionView].[ActualContrastYield], [dbo].[cos_ProductionView].[RequirePP], [dbo].[cos_ProductionView].[ProductPackDate], [dbo].[cos_ProductionView].[SmplApprovalDate], [dbo].[cos_ProductionView].[LC_DueDate], [dbo].[cos_ProductionView].[OKToShip], [dbo].[cos_ProductionView].[ETA_ChinaDate], [dbo].[cos_ProductionView].[ActualShippedDate], [dbo].[cos_ProductionView].[ShippingMode], [dbo].[cos_ProductionView].[TargetPort], [dbo].[cos_ProductionView].[ContainerOrLcl], [dbo].[cos_ProductionView].[Packaging], [dbo].[cos_ProductionView].[Comment1], [dbo].[cos_ProductionView].[Merchandiser], [dbo].[cos_ProductionView].[InputDatetime], [dbo].[cos_ProductionView].[OrderedDatetime] FROM [dbo].[cos_ProductionView] WHERE [dbo].[cos_ProductionView].[Customer] = @Customer0 AND [cos_ProductionView].[OrderedDatetime] BETWEEN @startOrderedDatetime AND @endOrderedDatetime;

and excepation infomation is said that can't convert from a string to a int32
Comments: ** Comment from web user: erickemp **

Fixed in Revision 441

COMMENTED ISSUE: Querying a view with Comparision.In operation it act as a Comparision.Equal

erickemp — Mon, 12 May 2008 18:15:43 GMT

Thanks for the report... I've fixed this for my next check-in...

COMMENTED ISSUE: ExecuteJoinedDataSet() Improperly Performs JOINs on 1-to-1 PK/FK Relations

erickemp — Mon, 12 May 2008 15:46:13 GMT

Hi there,

I found a bug with the scaffold control when doing a 1 to 1 table mapping, a full description of the bug, the tables used and where the problem can fixed is shown here:
http://forums.subsonicproject.com/forums/p/3201/13278.aspx#13278

Basically the wrong primarykeyvalue is being passed when editing a grid row item

Regards DotnetShadow
Comments: ** Comment from web user: erickemp **

Fixed in Revision 440.

COMMENTED ISSUE: Scaffold Control [BUG]: 1 to 1 Relationship Problem

erickemp — Mon, 12 May 2008 15:44:40 GMT

Thanks for the report... I've fixed this for my next check-in...

COMMENTED ISSUE: DB.Update() Does Not Set IsLoaded="true"

erickemp — Mon, 12 May 2008 15:13:28 GMT

The issue is that the isloaded flag is not set after an insert and therefore subsequent database calls get no dirty columns.
Comments: ** Comment from web user: erickemp **

Fixed in Revision 439.

COMMENTED ISSUE: DB.Update() throws an error with empty set clause

erickemp — Mon, 12 May 2008 15:07:23 GMT

The issue is that the isloaded flag is not set after an insert and therefore subsequent database calls get no dirty columns.
Comments: ** Comment from web user: erickemp **

Thanks for the report... I've fixed this for my next check-in...

CREATED ISSUE: Scaffold Control [BUG]: 1 to 1 Relationship Problem

robsworld2006 — Mon, 12 May 2008 12:54:48 GMT

CREATED ISSUE: Querying a view with Comparision.In operation it act as a Comparision.Equal

lin2000y — Mon, 12 May 2008 02:29:35 GMT

COMMENTED ISSUE: Scaffold Problem: Operand type clash: uniqueidentifier is incompatible with int

robsworld2006 — Mon, 12 May 2008 02:23:52 GMT

You can close this issue because I think it's a composite key problem rather than scaffold control bug

Thanks
Regards DotnetShadow

COMMENTED ISSUE: Scaffold Problem: Operand type clash: uniqueidentifier is incompatible with int

robsworld2006 — Mon, 12 May 2008 01:59:36 GMT

The problem I think lies with how I defined my table

I have 2 tables:

Table1: UserCompetitoin
composite key: UserID PK, CompID PK

Table2: Portfolio
ID PK
UserID FK
CompID FK

What is happening is that the sql being provided by the scaffold control joins on the right columns but only matches the first column as follows:

Query.cs line: 1731
ExecuteJoinedDataSet
strJoin = { INNER JOIN [dbo].[UserCompetition] J1 ON [dbo].[Portfolio].[UserId] = [J1].[UserId] INNER JOIN [dbo].[UserCompetition] J2 ON [dbo].[Portfolio].[CompetitionID] = [J2].[UserId]} <---- should be competitionID

I'm not sure if this is possible?

Regards DotnetShadow

CREATED ISSUE: Scaffold Problem: Operand type clash: uniqueidentifier is incompatible with int

robsworld2006 — Mon, 12 May 2008 01:10:39 GMT