Silverlight Toolkit

Created Issue: TreeView does not select the correct item when setting IsSelected and parent is not expanded

JustinJosefAngel — Fri, 09 Jan 2009 04:04:29 GMT

Originated from forum post: http://silverlight.net/forums/t/60645.aspx

TreeView does not select the correct item when setting IsSelected and parent TreeViewItem is not expanded.

When setting TreeViewItem.IsSelected and the TreeViewItem is not visible (because it's parent TreeViewItem is collapsed) it does not become the TreeViewItem.SelectedItem. Rather, the first item in the TreeView does.

Repro:
<Canvas>
<controls:TreeView x:Name="theTree" Width="250" Height="250">
<controls:TreeViewItem Header="hello" x:Name="hello" />
<controls:TreeViewItem Header="fruits" x:Name="fruits" IsExpanded="False" >
<controls:TreeViewItem Header="apple" x:Name="apple"/>
<controls:TreeViewItem Header="orange" x:Name="orange"/>
</controls:TreeViewItem>
</controls:TreeView>
<Button Canvas.Top="270" Content="Select apple " x:Name="btnSelectApple" />
</Canvas>

public Window7()
{
InitializeComponent();
btnSelectApple.Click += new RoutedEventHandler(btnSelectApple_Click);
theTree.SelectedItemChanged += new RoutedPropertyChangedEventHandler<object>(theTree_SelectedItemChanged);
}

void theTree_SelectedItemChanged(object sender, RoutedPropertyChangedEventArgs<object> e)
{
btnSelectApple.Content = ((TreeViewItem)e.NewValue).Header;
}

void btnSelectApple_Click(object sender, RoutedEventArgs e)
{
apple.IsSelected = true;
}

1. Click the Button.

Result:
In Silverlight, the button content becomes "hello". That is because setting the TreeViewItem.IsSelected=True when the TreeViewItem is not visible, causes the 1st item to get selected.
In WPF, the button content becomes "apple". That is the correct behavior.

Created Issue: ImplicitStyleManager does not support drilling down into Popups

JustinJosefAngel — Fri, 09 Jan 2009 03:12:44 GMT

ImplicitStyleManager does not support drilling down into Popups natively.

Repro:
{code:xml}
<Grid x:Name="LayoutRoot" Background="White" Theming:ImplicitStyleManager.ApplyMode="Auto"
Theming:ImplicitStyleManager.ResourceDictionaryUri="SL_RTM_VS;component/Microsoft.Windows.Controls.Theming.RainierOrange.xaml">
<Button Content="Hello World" HorizontalAlignment="Stretch" VerticalAlignment="Top" Click="Button_Click"/>
<Popup x:Name="popup">
<Button Content="Hello World" />
</Popup>
</Grid>
{code:xml}
{code:c#}
private void Button_Click(object sender, RoutedEventArgs e)
{
popup.IsOpen = !popup.IsOpen;
}
{code:c#}

When running this code the internal button in the Popup.Child will not get styled.

The problem is caused due to a namescoping issue with Popup.Child not being in the Visual tree.

Workaround:
{code:c#}
popup.LayoutUpdated += new EventHandler(popup_LayoutUpdated);

void popup_LayoutUpdated(object sender, EventArgs e)
{
popup.LayoutUpdated -= new EventHandler(popup_LayoutUpdated);
ImplicitStyleManager.SetApplyMode((FrameworkElement) popup.Child, ImplicitStylesApplyMode.Auto);
ImplicitStyleManager.SetResourceDictionaryUri((FrameworkElement) popup.Child, new Uri("SL_RTM_VS;component/Microsoft.Windows.Controls.Theming.RainierOrange.xaml", UriKind.Relative));
}
{code:c#}

Closed Issue: Combobox databinding issue

shawnoster — Thu, 08 Jan 2009 23:26:48 GMT

Hi,

I am getting the below exception when trying to bind the data to Combo box through List<T>.

Message: "Error HRESULT E_FAIL has been returned from a call to a COM component."

StackTrace:

at MS.Internal.XcpImports.CheckHResult(UInt32 hr)
at MS.Internal.XcpImports.SetValue(INativeCoreTypeWrapper obj, DependencyProperty property, DependencyObject doh)
at MS.Internal.XcpImports.SetValue(INativeCoreTypeWrapper doh, DependencyProperty property, Object obj)
at System.Windows.DependencyObject.SetObjectValueToCore(DependencyProperty dp, Object value)
at System.Windows.DependencyObject.SetValueInternal(DependencyProperty dp, Object value, Boolean allowReadOnlySet, Boolean isSetByStyle, Boolean isSetByBuiltInStyle)
at System.Windows.DependencyObject.SetValueInternal(DependencyProperty dp, Object value)
at System.Windows.DependencyObject.SetValue(DependencyProperty dp, Object value)
at System.Windows.Controls.Control.set_DefaultStyleKey(Object value)
at System.Windows.Controls.ContentControl..ctor()
at System.Windows.CoreTypes.GetCoreWrapper(Int32 typeId)
at MS.Internal.ManagedPeerTable.EnsureManagedPeer(IntPtr unmanagedPointer, Int32 typeIndex, Type type, Boolean preserveManagedObjectReference)
at MS.Internal.ManagedPeerTable.EnsureManagedPeer(IntPtr unmanagedPointer, Int32 typeIndex, Type type)
at MS.Internal.XcpImports.ConvertDO(IntPtr doPointer, Int32 typeIndex, Boolean releaseObjectReference)
at MS.Internal.XcpImports.ConvertType(CValue outVal, Int32 typeIndex, Boolean releaseObjectReference)
at MS.Internal.XcpImports.FocusManager_GetFocusedElement()
at System.Windows.Input.FocusManager.GetFocusedElement() at System.Windows.Controls.ComboBox.HasFocus()
at System.Windows.Controls.Primitives.Selector.SetFocusedItem(Int32 index, Boolean scrollIntoView)
at System.Windows.Controls.Primitives.Selector.OnItemsChanged(NotifyCollectionChangedEventArgs e)
at System.Windows.Controls.ItemsControl.RaiseOnItemsChanged(NotifyCollectionChangedEventArgs e)
at System.Windows.Controls.ItemCollection.NotifyItemsControl(NotifyCollectionChangedEventArgs e)
at System.Windows.Controls.ItemCollection.AddInternal(Object value)
at System.Windows.PresentationFrameworkCollection`1.Add(T value)
Comments: I'm closing this issue because ComboBox isn't a control in the Silverlight Toolkit. A better place to discuss this issue would be on the Controls forum on Silverlight.net.

Commented Feature: Is it possible to program the scroll wheel in the examples.

anvimi — Thu, 08 Jan 2009 20:11:19 GMT

I was wonder if perhaps in the next control samples release they could program the scroll wheel on the longer siverlight views.

I find myself clicking the right pane and rolling the scroll wheel down by instinct, all the time.

A suggestion for possible improvement..
Comments: ** Comment from web user: anvimi **

Yeah, pretty annoying to say the least, hopefully it's not "by design" and will be fixed in the next releases.

Commented Issue: Combobox databinding issue

rajesh_a_kumar — Thu, 08 Jan 2009 06:38:27 GMT

Can someone please mark it as Critical ? I am unable to change the status.

Created Issue: Combobox databinding issue

rajesh_a_kumar — Thu, 08 Jan 2009 06:36:32 GMT

Closed Issue: Theming Error when add DataGrid Control to TabItem

shawnoster — Tue, 06 Jan 2009 23:26:05 GMT

Hi,

I use ImplicitStyleManager to them my silverlight page, but I got error when I add DataGrid to TabItem control. I try to replace DataGrid with a Button then It works well. could you all pay some attention to this error?

Boren

Thank!
Comments: Closing as a duplicate of workitem #981
http://www.codeplex.com/Silverlight/WorkItem/View.aspx?WorkItemId=981

Reopened Issue: AutoCompleteBox: Make SelectedItem property settable

slkit — Tue, 06 Jan 2009 23:14:38 GMT

Originatin from the following post:
http://silverlight.net/forums/p/56216/144632.aspx#144632

Feature request:
The SeletedItem property is now read-only.
Make it settable so an existing item in the ItemsSource can be programatically selected.

Setting the SelectedItem would change the Text property and raise the SelectionChanged event.
If the item was not in the list it would update the text but not raise any events.
Basically the same behavior as when you typed a word which was not in the list.

Reopened Issue: Poor performance of sample application

slkit — Tue, 06 Jan 2009 23:14:33 GMT

The performance of the sample page is horrible. this cannot be it. what is the good of animations if they dont run smoothly?
that is certainly not how silverlight was meant to perform.
i imagine lots of images etc. have been added as uncompiled resources loaded at runtime. they need to be compiled, otherwise
the thing doesent look nice at all.
great job, though!

Updated Wiki: Home

shawnoster — Tue, 06 Jan 2009 22:33:47 GMT

What is the Silverlight Toolkit?

The Silverlight Toolkit is a collection of Silverlight controls, components and utilities made available outside the normal Silverlight release cycle. It adds new functionality quickly for designers and developers, and provides the community an efficient way to help shape product development by contributing ideas and bug reports. It includes full source code, unit tests, samples and documentation for 12 new controls covering charting, styling, layout, and user input.

Get Started

Download the latest release
Visit our online Silverlight Toolkit sample
Take the guided tour of the Silverlight Toolkit: Part 1 - Controls, Part 2 - Charting and Part 3 - Theming

Suggestions? Features? Questions?

Ask questions in our Silverlight Toolkit forum on Silverlight.net. The forum is the best resource for Silverlight Toolkit Q&A.
Add bugs or feature requests to the Issue Tracker. Help us shape the Silverlight Toolkit with your feedback!
Read more about the Silverlight Toolkit on our Team Members RSS feed

How is the Silverlight Toolkit Built?

We use an iterative, evolutionary development model to release new controls and updates often and get feedback from the community to our development team quickly. With access to source code, unit tests and the infrastructure magic we use internally, the community can let us know what it likes and what it wants to change. Anyone can download the source code and start exploring. This transparency will allow the community to help us prioritize features based on real-world usage and actual customer scenarios. We also want to make it easy to reuse skills and source code which is why all our components are designed with Windows Presentation Foundation in mind and the Silverlight Toolkit is released under the Microsoft Public License.

Silverlight Toolkit December 2008 Overview

The Silverlight Toolkit defines four Quality Bands that describe the stability and finish-level of each component. Below is a summary of where the components currently in the Silverlight Toolkit fall within the quality bands. Read the complete list of changes in the Silverlight Toolkit December 2008 release from the November 2008 release.

Components in the Stable Quality Band

Components in the Preview Quality Band

Themes

In addition to great controls, the Toolkit also includes a beautiful assortment of professional themes to make your applications stand out and improve the overall look-and-feel of your Silverlight UI. See the overview on Theming for more information.

Team Member's Blogs

Created Issue: Setting focus on TreeView selects first item

uooq — Tue, 06 Jan 2009 20:05:19 GMT

It seems that whenever you set focus to a TreeView, the selected item changes to the first one. I created a very simple app, with just a tree view and a button-- the button's code behind is simply a Focus() call to the tree view. The xaml looks like this:

<UserControl x:Class="TreeViewWeirdness.Page"
xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
xmlns:toolkit="clr-namespace:Microsoft.Windows.Controls;assembly=Microsoft.Windows.Controls"
Width="200" Height="200">
<StackPanel x:Name="LayoutRoot" Background="White">
<toolkit:TreeView x:Name="TheTree">
<toolkit:TreeViewItem Header="Foo" />
<toolkit:TreeViewItem Header="Bar" />
<toolkit:TreeViewItem Header="Bat" />
<toolkit:TreeViewItem Header="Hey" />
</toolkit:TreeView>
<Button Content="Set Focus On TreeView" Click="Button_Click" Margin="10" />
</StackPanel>
</UserControl>

and the C# like this:

private void Button_Click(object sender, RoutedEventArgs e)
{
TheTree.Focus();
}

If you click the button the selected item of the treeview will go to the first item.

IMHO this behavior is a bug... for our application, it's causing a very confusing context change as we have a details view driven off of the treeview's selection changed event... Any plans for a fix/change and/or any suggestions for a workaround (I'm currently looking at overriding the OnGotFocus method).

Commented Feature: Please port the data visualization(charts) to WPF

Wardy — Tue, 06 Jan 2009 14:20:22 GMT

You have done a great amount of work to come up with some very nice charts for silverlight.
It would be great to have this functionality in WPF environments as well, and the effort should not be too hard (good bang for the buck).
Thank you,
Mike Castillo
Comments: ** Comment from web user: Wardy **

I wouldn't bother, i'm sure I saw something about how u can host silverlight components within a wpf application at microsoft last month, already in the current version of .net

Also I noticed that silverlight is planned to be able to jump out of the browser completely to run on its own pretty much like java does, so why not just use this stuff as it is and let the developers concentrate on the silverlight stuff !!

Created Issue: Changes to Series.LegendItemStyle after Series.Title do not take effect

davidans — Mon, 05 Jan 2009 23:34:49 GMT

Forum post: http://silverlight.net/forums/t/62975.aspx

Setting Series.Title creates a LegendItem instance at the time of the set; DataPointSeries.LegendItemStyleProperty needs a property change handler to update the style for that LegendItem instance. Currently, there is no handler, so once the LegendItem is created, subsequent changes to LegendItemStyle have no effect. (This works fine if the order of the setters for LegendItemStyle and Title are reversed because when the LegendItem is created by the Title setter, it applies the previously set LegendItemStyle at that time.)

Complete demo:
<charting:Chart>
<charting:Chart.Resources>
<Style x:Key="MyLegendItemStyle" TargetType="charting:LegendItem">
<Setter Property="FontSize" Value="50"/>
</Style>
</charting:Chart.Resources>
<charting:Chart.Series>
<charting:ColumnSeries Title="MyTitle" LegendItemStyle="{StaticResource MyLegendItemStyle}">
<charting:ColumnSeries.ItemsSource>
<controls:ObjectCollection>
<sys:Double>1</sys:Double>
<sys:Double>2</sys:Double>
<sys:Double>3</sys:Double>
<sys:Double>4</sys:Double>
</controls:ObjectCollection>
</charting:ColumnSeries.ItemsSource>
</charting:ColumnSeries>
</charting:Chart.Series>
</charting:Chart>

Commented Issue: Can't get LegendItemStyle to work in december release

JustinJosefAngel — Mon, 05 Jan 2009 18:47:56 GMT

There where no problem to style the LegendItem in Chart with the LegendItemStyle property in the november release. In the december release however, I cant get the style to apply to the LegendItems.

The LegendItemStyle property has changed class from DynamicSeries to DataPointSeries. If there is not any major change to how LegendItemStyle is supposed to be used, I think there might be a bug.
Comments: ** Comment from web user: JustinJosefAngel **

See forum post @ http://silverlight.net/forums/t/62975.aspx

Commented Feature: TreeView Suggestions (Drag & Drop, Inline Node Editing)

Wardy — Mon, 05 Jan 2009 16:29:36 GMT

I would like to suggest adding drag and drop to the TreeNodes and an event fired when that happens and also inline node editing.
Comments: ** Comment from web user: Wardy **

any ideas when this will be looked at guys ? i'm just curious because I need this functionality for a project i'm working on and a mate has already created a treeview, trouble is he is travelling round the world at the moment so I would rather use the "official" treeview for the support.

It would be cool if we could also create context menus on right clicks too, this would bring it online with more commonly known desktop application functionality.

Keep up the good work though :)

Created Issue: Can't get LegendItemStyle to work in december release

Svartsau — Mon, 05 Jan 2009 09:55:17 GMT

Created Issue: Create property to always show Minimum value or Maximum value

rpedersen — Sat, 03 Jan 2009 20:51:42 GMT

There are times when specifing the minimum value and/or maximum value in combination with an interval that the minimum and maximum values aren't rendered for the user to see. Please add some kind of switch to force the rendering of the minimum and maximum values of the plot area.

Reviewed: Silverlight Toolkit December 2008 (Jan 03, 2009)

hristo — Sat, 03 Jan 2009 18:51:51 GMT

Rated 5 Stars (out of 5) - Excelent work

Created Issue: Hefty recursive loop when LineSeries is resized

rdschauer — Thu, 01 Jan 2009 04:22:04 GMT

The method "DataPointSeries.UpdateAllDataPoints" sets a boolean member variable "UpdatingAllDataPoints", which is used by "LineSeries.UpdateDataPoint" to avoid a recursive loop. Unfortunately, it seems, that "UpdateDataPoint" can invoke events that indirectly cause a recursive call to "DataPointSeries.UpdateAllDataPoints", which then unsets the "UpdatingAllDataPoints". When returning to the outer "DataPointsSeries.UpdateAllDataPoints" method, it finds the "UpdatingAllDataPoints" set to false, which causes an O(n^2) loop through all data points in "LineSeries.UpdateDataPoint". This is "very" expensive when you have quite a few points on the chart.

Hope this makes sense. My code is changing the Minimum / Maximum properties of a DateTimeAxis, which causes this problem. It's repeatable, but I would need to dig into this a bit more to figure out all gory details :).

DataPointSeries.UpdateAllDataPoints:

protected virtual void UpdateAllDataPoints()
{
UpdatingAllDataPoints = true;

DetachEventHandlersFromDataPoints();
try
{
OnBeforeUpdateDataPoints();

foreach (DataPoint dataPoint in ActiveDataPoints)
{
UpdateDataPoint(dataPoint);
}

OnAfterUpdateDataPoints();
}
finally
{
AttachEventHandlersToDataPoints();
UpdatingAllDataPoints = false;
}
}

LineSeries.UpdateDataPoint:

protected override void UpdateDataPoint(DataPoint dataPoint)
{
double maximum = ActualDependentRangeAxis.GetPlotAreaCoordinate(ActualDependentRangeAxis.Range.Maximum);
if (ValueHelper.CanGraph(maximum))
{
double x = ActualIndependentRangeAxis.GetPlotAreaCoordinate(ValueHelper.ToComparable(dataPoint.ActualIndependentValue));
double y = ActualDependentRangeAxis.GetPlotAreaCoordinate(ValueHelper.ToDouble(dataPoint.ActualDependentValue));

if (ValueHelper.CanGraph(x) && ValueHelper.CanGraph(y))
{
if (!double.IsNaN(MarkerHeight))
{
dataPoint.Height = MarkerHeight;
}
if (!double.IsNaN(MarkerWidth))
{
dataPoint.Width = MarkerWidth;
}

// Call UpdateLayout to ensure ActualWidth/ActualHeight are correct
if (dataPoint.ActualWidth == 0.0 || dataPoint.ActualHeight == 0.0)
{
dataPoint.UpdateLayout();
}

double coordinateY = Math.Round(maximum - (y + (dataPoint.ActualHeight / 2)));
Canvas.SetTop(dataPoint, coordinateY);
double coordinateX = Math.Round(x - (dataPoint.ActualWidth / 2));
Canvas.SetLeft(dataPoint, coordinateX);
}

====================================>
if (!UpdatingAllDataPoints)
{
UpdatePointsCollection();
}
=====================================>

}
}

Created Issue: DataPointStyle is not respected when set programmaticly

JustinJosefAngel — Wed, 31 Dec 2008 20:08:35 GMT

When setting DataPointStyle from XAML, it is respected.
However, if setting it from code it is ignored.

Repro:
XAML:
<charting:Chart x:Name="chart">
<charting:ColumnSeries ItemsSource="{Binding}"
DependentValueBinding="{Binding Value}"
IndependentValueBinding="{Binding Key}">
</charting:ColumnSeries>
</charting:Chart>

code:
public SilverlightControl32()
{
InitializeComponent();

System.Windows.Style DataPointStyle = new Style(typeof(ColumnDataPoint));
DataPointStyle.Setters.Add(new Setter(ColumnDataPoint.MaxWidthProperty, 10.0));
((ColumnSeries) chart.Series[0]).DataPointStyle = DataPointStyle;

this.Loaded += new RoutedEventHandler(SilverlightControl32_Loaded);
}

void SilverlightControl32_Loaded(object sender, RoutedEventArgs e)
{
chart.DataContext = new KeyValuePair<string, int>[]
{
new KeyValuePair<string, int>("hello", 1),
new KeyValuePair<string, int>("world", 2),
new KeyValuePair<string, int>("foo", 3),
new KeyValuePair<string, int>("bar", 4)
};
}